Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for etcd2 from cluster/images/etcd image #80037

Merged
merged 2 commits into from Jul 12, 2019
Merged

Remove support for etcd2 from cluster/images/etcd image #80037

merged 2 commits into from Jul 12, 2019

Conversation

dims
Copy link
Member

@dims dims commented Jul 11, 2019

Removes etcd2 code and images.
Etcd2 is no longer supported as of 1.13, so rollback and management
tools for etcd2 should not be shipped any longer. If it is still desired
the older versions of the image can be used.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #80036

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

etcd migration image no longer supports etcd2 version.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2019
@dims
Copy link
Member Author

dims commented Jul 11, 2019

/assign @jpbetz @liggitt
cc @wenjiaswe @wojtek-t

@dims
Copy link
Member Author

dims commented Jul 11, 2019

/priority important-soon
/area code-organization

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 11, 2019
@liggitt
Copy link
Member

liggitt commented Jul 11, 2019

/approve

@jpbetz has lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
@wojtek-t
Copy link
Member

LGTM, but I will let @jpbetz to finally lgtm it.

@roycaihw
Copy link
Member

/cc @jingyih @wenjiaswe

@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: jingyih.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jingyih @wenjiaswe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims dims force-pushed the remove-support-for-etcd2-from-images-etcd branch from b5fe807 to 318288d Compare July 11, 2019 21:04
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyih
Copy link
Contributor

jingyih commented Jul 11, 2019

Do we still need the upgrade and downgrade tests that involve etcd2?

https://github.com/kubernetes/kubernetes/blob/318288dae6b0d38b04b5998823543dd9eb1afa2a/cluster/images/etcd/migrate/integration_test.go#L56-L57

https://github.com/kubernetes/kubernetes/blob/318288dae6b0d38b04b5998823543dd9eb1afa2a/cluster/images/etcd/migrate/integration_test.go#L64-L65

@dims
Copy link
Member Author

dims commented Jul 12, 2019

/retest

dims added 2 commits July 11, 2019 21:20
@dims
Remove support for etcd2 from cluster/images/etcd image
f58f126 
Removes etcd2 code and images.
Etcd2 is no longer supported as of 1.13, so rollback and management
tools for etcd2 should not be shipped any longer. If it is still desired
the older versions of the image can be used.

Change-Id: I516c40067f0a57c42d2a6ab4612071c5e556a005
@dims
Update revision number for the image
88b0be7
@dims dims force-pushed the remove-support-for-etcd2-from-images-etcd branch from 318288d to 88b0be7 Compare July 12, 2019 01:21
@dims
Copy link
Member Author

dims commented Jul 12, 2019

@jingyih fixed. PTAL

@jingyih
Copy link
Contributor

jingyih commented Jul 12, 2019

lgtm. Thanks!

@dims
Copy link
Member Author

dims commented Jul 12, 2019

@jpbetz @roycaihw can you please /lgtm based on the lgtm from @jingyih above?

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit aaad86c into kubernetes:master Jul 12, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jpbetz jpbetz

@liggitt liggitt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Remove support for etcd2 from cluster/images/etcd image
7 participants
@dims @liggitt @wojtek-t @roycaihw @k8s-ci-robot @jingyih @jpbetz